ktlint_fix: use java from toolchain rather than from default PATH
#1375
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmivankov
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
restingbull
reviewed
Oct 8, 2025
kotlin/internal/lint/ktlint_fix.bzl
Outdated
| cfg = "target", | ||
| ), | ||
| "_java": attr.label( | ||
| default = "@bazel_tools//tools/jdk:current_java_runtime", |
There was a problem hiding this comment.
Should be pulled from the java runtime toolchain -- @bazel_tools//tools/jdk:runtime_toolchain_type, rather than an attribute.
This is to ensure that the binary will respect platform during compilation. With RBE, it's not unusual to build binaries for a target platform on an incompatible exec. e.g. it ain't always host. :)
Otherwise, looks good.
Bencodes
reviewed
Oct 8, 2025
kotlin/internal/lint/ktlint_fix.bzl
Outdated
| args = " ".join(args), | ||
| srcs = " ".join([src.path for src in ctx.files.srcs]), | ||
| binjava = ctx.attr._java[java_common.JavaRuntimeInfo].java_executable_runfiles_path, | ||
| binjava = ctx.toolchains["@bazel_tools//tools/jdk:runtime_toolchain_type"].java_runtime.java_executable_runfiles_path, |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1372